<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
<div class="moz-cite-prefix">On 3/8/16 2:02 PM, Tim Delaney wrote:<br>
</div>
<blockquote
cite="mid:CAN8CLgkZ3tZ=OE40vt+H3u2d+CEmMp0aTZWrO3tRNetTrTwTNQ@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">On 9 March 2016 at 04:42, Durham
Goode <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:durham@fb.com" target="_blank">durham@fb.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Your
change helps a bunch in the case where ancestors aren't
present, but that's pretty rare in our code base at least
(since we have very few merges). Here is the before and
after smartlog output from my hg repo: <a
moz-do-not-send="true"
href="https://urldefense.proofpoint.com/v2/url?u=https-3A__bpaste.net_show_2093d7bad9c1&d=CwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=nuarHzhP1wi1T9iURRCj1A&m=Ix7YLrzTSql7jLWOBs__ZDQLdJjoyuycoz3rbHzG16M&s=XWseVzXeEz1WRMYHFNEkVeXWNQ8rm7PMkOKRGdf50yg&e="
rel="noreferrer" target="_blank"><a class="moz-txt-link-freetext" href="https://bpaste.net/show/2093d7bad9c1">https://bpaste.net/show/2093d7bad9c1</a></a><br>
<br>
I actually find the dashed line detracts from the general
glance-ability of the data, and am not sure we'd want to
replace smartlog with this output just yet. Is there a
config option to disable these line stylings?</blockquote>
<div><br>
</div>
<div>How does it look to you if you replace colon (:) with
exclamation mark (!)? Note: need to be a little careful
with find/replace to avoid changing colons in the text.
Personally, I don't like it, but it does give a more solid
but broken line.</div>
</div>
</div>
</div>
</blockquote>
Martijn tried it with a exclamation mark before (I saw an early
prototype) and I think that was also not great (it was too subtle in
some cases, and didn't really produce the dashed effect that would
convey the not-my-parent notion).<br>
<blockquote
cite="mid:CAN8CLgkZ3tZ=OE40vt+H3u2d+CEmMp0aTZWrO3tRNetTrTwTNQ@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div><br>
</div>
<div>Another idea - do we need the entire path showing the
grandparent relationship? Would it be enough to just have
it at the start (and probably end) of the path?</div>
</div>
</div>
</div>
</blockquote>
This is what smartlog does, to some degree. But smartlog inserts a
full node (with no text) into the graph algorithm and draws an
ellipsis on the line for that node. Having ':' in a couple spots on
the line might be interesting. I'd probably not have the ':' as the
first character in the line. Replacing the | on the blank line
following the commit makes it obvious it's a break in the line that
occurs just after the commit (having the : on the same line as some
of the commit text drew my eye to that line and made me think the :
was highlighting some aspect of that line.<br>
<br>
<div>
<div>@ 4932aa mjpieters</div>
<div>| graphmod: end edges to missing parents early.</div>
<div>:<br>
</div>
<div>| o d01268 durham</div>
<div>| | parsers: optimize filtered headrevs logic</div>
<div>| :<br>
</div>
<div>| | o 55f8ae durham</div>
<div>| |/ branchmap: check node against changelog instead of
repo</div>
<div>| :<br>
</div>
| |
<div>o | 5cef34 durham hgvip/release-2016-02-17</div>
<div>| | test: remove dependency on $PYTHONDIR</div>
<div>| |</div>
<div>o | 4f99a5 durham</div>
<div>| | test: quick fix for test-hook</div>
<div>| |</div>
<div>o | 95bf01 quark fbcrew/@</div>
<div>| | chg: forward umask from client to server</div>
<div>| |</div>
<div>o | e48d77 quark</div>
<div>| | chgserver: add setumask method</div>
<div>| |<br>
<br>
and<br>
<br>
<div>
<div>o changeset: 32:d06dffa21a31</div>
<div>|\ parent: 27:886ed638191b</div>
<div>| | parent: 31:621d83e11f67</div>
<div>| | user: test</div>
<div>| | date: Thu Jan 01 00:00:32 1970 +0000</div>
<div>| | summary: (32) expand</div>
<div>| :<br>
</div>
<div>o | changeset: 31:621d83e11f67</div>
<div>|\| parent: 21:d42a756af44d</div>
<div>| | parent: 30:6e11cd4b648f</div>
<div>| | date: Thu Jan 01 00:00:31 1970 +0000</div>
<div>| | summary: (31) expand</div>
<div>| |<br>
</div>
<div>o | changeset: 30:6e11cd4b648f</div>
<div>|\ \ parent: 28:44ecd0b9ae99</div>
<div>| ~ | parent: 29:cd9bb2be7593</div>
<div>| | user: test</div>
<div>| | date: Thu Jan 01 00:00:30 1970 +0000</div>
<div>| | summary: (30) expand</div>
<div>| /</div>
<div>o | changeset: 28:44ecd0b9ae99</div>
</div>
<br>
</div>
</div>
</body>
</html>