<div dir="ltr">On Wed, Apr 6, 2016 at 9:44 AM, Augie Fackler <span dir="ltr"><<a href="mailto:raf@durin42.com" target="_blank">raf@durin42.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Wed, Apr 06, 2016 at 03:34:30PM +0200, Axel Hecht wrote:<br>
> On 06/04/16 15:25, Matt Mackall wrote:<br>
> >On Wed, 2016-04-06 at 14:36 +0200, Axel Hecht wrote:<br>
> >># HG changeset patch<br>
> >># User Axel Hecht <<a href="mailto:axel@pike.org">axel@pike.org</a>><br>
> >># Date 1442329051 -7200<br>
> >># Tue Sep 15 16:57:31 2015 +0200<br>
> >># Node ID 674bd25c2339aa4b2be714b8d763c93c8eb07b36<br>
> >># Parent 8c4d24b58c23030616d7f65a4ae3a392e8ef9d0d<br>
> >>Drop support for python 2.4 and 2.5, as is core hg.<br>
> >The maintenance burden for 2.4 support in hglib is currently zero, so I don't<br>
> >see a reason to do this. If, for some crazy reason, someone has a Python2.4-<br>
> >based hglib app that they don't want to update, they needn't run it against a<br>
> >Python2.4-compatible hg. Since basically every 2.x release required fixes in<br>
> >Mercurial itself, this isn't a particularly unlikely scenario[1].<br>
> ><br>
> >On the other hand, if you're planning substantial work on hglib that depends on<br>
> >2.6 features, I'm happy to listen.<br>
> I removed those based on a conversation I had with gps about other patches<br>
> that I'm about to submit after this.<br>
> <a href="https://bitbucket.org/pike/python-hglib/commits/c82671bcb9c61d96cdaa8116a78dd184c18f5e53#comment-1970588" rel="noreferrer" target="_blank">https://bitbucket.org/pike/python-hglib/commits/c82671bcb9c61d96cdaa8116a78dd184c18f5e53#comment-1970588</a><br>
> was were we discussed this.<br>
><br>
> In this particular case,<br>
><br>
> - return context.changectx(self, changeid)<br>
> + try:<br>
> + return context.changectx(self, changeid)<br>
> + except ValueError as e:<br>
> + raise IndexError(*e.args)<br>
><br>
> only works this way in non-ancient versions of python.<br>
><br>
> The other patches are for<br>
> <a href="https://bz.mercurial-scm.org/buglist.cgi?bug_id=4510,4511,4644" rel="noreferrer" target="_blank">https://bz.mercurial-scm.org/buglist.cgi?bug_id=4510,4511,4644</a>, one patch<br>
> each.<br>
><br>
> I didn't mass-submit them all 'cause the wiki said so, but I'm happy to send<br>
> them over for context.<br>
<br>
</div></div>If it's 5 or so patches, feel free to send them all out. If it's<br>
mostly the exception syntax, I'm not sure that quite justifies<br>
ditching 2.4 here, but I could be pretty easily persuaded.<br>
<div class="HOEnZb"><div class="h5"><br></div></div></blockquote><div><br></div><div>We could benefit from context managers in hglib. As it stands today, it is relatively easy to forget to close the connection, leaving an orphaned process.<br><br></div><div>Also, it would be nice to make hglib compatible with Python 3.5, which won't be possible as long as we support 2.4/2.5.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
><br>
> Axel<br>
><br>
> ><br>
> >[1] Compare that to the Perl-based db-backed fulltext search engine I have<br>
> >running on my mail server that's been running unattended for about 18 years.<br>
> >--<br>
> >Mathematics is the supreme nostalgia of our time.<br>
> ><br>
><br>
> _______________________________________________<br>
> Mercurial-devel mailing list<br>
> <a href="mailto:Mercurial-devel@mercurial-scm.org">Mercurial-devel@mercurial-scm.org</a><br>
> <a href="https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel" rel="noreferrer" target="_blank">https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel</a><br>
_______________________________________________<br>
Mercurial-devel mailing list<br>
<a href="mailto:Mercurial-devel@mercurial-scm.org">Mercurial-devel@mercurial-scm.org</a><br>
<a href="https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel" rel="noreferrer" target="_blank">https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel</a><br>
</div></div></blockquote></div><br></div></div>