<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Dec 24, 2016, at 1:34 PM, Gregory Szorc <<a href="mailto:gregory.szorc@gmail.com" class="">gregory.szorc@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Where do we stand with this series? I was waiting for feedback, but none arrived.<br class=""></div></div></blockquote><div><br class=""></div><div>I believe I had asked that others look at it, and hearing nothing, we should conclude nobody else cares and move on and queue it with whatever little bits I had to say on this v2. Does that work for you?</div><div><br class=""></div><div>(I did give you feedback, right?)</div><br class=""><blockquote type="cite" class=""><div class=""><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">I'd like to get zstd into the wire protocol and revlogs for 4.1, otherwise it isn't very useful (I've been holding off patchbombing the revlog series because I already have enough things in flight). With the holidays, we effectively have 2 weeks before freeze.</div></div></blockquote><div><br class=""></div><div>Agreed.</div><br class=""><blockquote type="cite" class=""><div class=""><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class="">FWIW, getting reviews this cycle has been extremely frustrating to me. I was planning on landing zstd, `hg debugupgraderepo`, `hg display`, and various polish work for more robust zstd integration in the 4.1 release. It's now looking like a good chunk of that work won't make it. The most frustrating part is that most of the code was ready in November :/ I think there needs to be a discussion about scaling code review (no later than the next sprint) because it's been obvious for a few months now that things aren't as well-oiled as they were several months ago.</div></div></blockquote></div><br class=""><div class="">Also agreed. Note that this one got lost while you were on vacation (or something?), and debugupgraderepo I left for marmoute at his explicit request, but I haven’t seen movement there.</div></body></html>