<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 24, 2019 at 7:25 PM Gregory Szorc <<a href="mailto:gregory.szorc@gmail.com">gregory.szorc@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 24, 2019 at 12:29 AM Pierre-Yves David <<a href="mailto:pierre-yves.david@ens-lyon.org" target="_blank">pierre-yves.david@ens-lyon.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"># HG changeset patch<br>
# User Pierre-Yves David <<a href="mailto:pierre-yves.david@octobus.net" target="_blank">pierre-yves.david@octobus.net</a>><br>
# Date 1556049342 -7200<br>
#      Tue Apr 23 21:55:42 2019 +0200<br>
# Node ID 26f277f0f415206036a57f17400284107816f00d<br>
# Parent  84bd6ae2d1f656dff1d494a03558c4edb58ebd31<br>
# EXP-Topic discovery-followup<br>
# Available At <a href="https://bitbucket.org/octobus/mercurial-devel/" rel="noreferrer" target="_blank">https://bitbucket.org/octobus/mercurial-devel/</a><br>
#              hg pull <a href="https://bitbucket.org/octobus/mercurial-devel/" rel="noreferrer" target="_blank">https://bitbucket.org/octobus/mercurial-devel/</a> -r 26f277f0f415<br>
httppeer: make sure we limit argument for older server not supporting batch<br></blockquote></div></div></blockquote><div><br></div><div>I believe this patch was in response to a question from me. I was asking if 'httppostargs' automatically upgraded the HTTP method from GET to POST and I thought it did not and that we relied on the use of the 'batch' request for that (which always used POST, I think). Joerg then replied that 'httppostargs' does upgrade from GET to POST, so I think this patch is not needed. Do you (both Greg and Pierre-Yves) agree?</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"></blockquote><div><br></div><div>Queued.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Most commands will still have some argument restriction when using 'GET' method<br>
instead of batching through POST.<br>
<br>
diff --git a/mercurial/httppeer.py b/mercurial/httppeer.py<br>
--- a/mercurial/httppeer.py<br>
+++ b/mercurial/httppeer.py<br>
@@ -382,7 +382,9 @@ class httppeer(wireprotov1peer.wirepeer)<br>
         self._path = path<br>
         self._url = url<br>
         self._caps = caps<br>
-        self.limitedarguments = caps is not None and 'httppostargs' not in caps<br>
+        self.limitedarguments = False<br>
+        if caps is None or 'batch' not in caps or 'httppostargs' not in caps:<br>
+            self.limitedarguments = True<br>
         self._urlopener = opener<br>
         self._requestbuilder = requestbuilder<br>
<br>
_______________________________________________<br>
Mercurial-devel mailing list<br>
<a href="mailto:Mercurial-devel@mercurial-scm.org" target="_blank">Mercurial-devel@mercurial-scm.org</a><br>
<a href="https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel" rel="noreferrer" target="_blank">https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel</a><br>
</blockquote></div></div>
_______________________________________________<br>
Mercurial-devel mailing list<br>
<a href="mailto:Mercurial-devel@mercurial-scm.org" target="_blank">Mercurial-devel@mercurial-scm.org</a><br>
<a href="https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel" rel="noreferrer" target="_blank">https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel</a><br>
</blockquote></div></div>