<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr"><strong>From: </strong>yuja (Yuya Nishihara) <span dir="ltr"><<a href="mailto:phabricator@mercurial-scm.org">phabricator@mercurial-scm.org</a>></span><br><strong>Date: </strong>Sat, May 11, 2019, 20:12<br><strong>To: </strong> <<a href="mailto:mercurial-devel@mercurial-scm.org">mercurial-devel@mercurial-scm.org</a>><br><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">yuja added a comment.<br>
<br>
<br>
  > +    def modified(self):<br>
  >  +        modified = set(self.files())<br>
  >  +        modified.difference_update(self.added())<br>
  >  +        modified.difference_update(self.removed())<br>
  >  +        return sorted(modified)<br>
  >  +    def added(self):<br>
  >  +        added = []<br>
  >  +        for f in self.files():<br>
  >  +            if not any(f in p for p in self.parents()):<br>
  >  +                added.append(f)<br>
  >  +        return added<br>
  >  +    def removed(self):<br>
  >  +        removed = []<br>
  >  +        for f in self.files():<br>
  >  +            if f not in self:<br>
  >  +                removed.append(f)<br>
  >  +        return removed<br>
<br>
  Do these definitions agree with the committablectx ones?<br>
  I think the committablectx calculates them based on the status from p1.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Oh, good point. I suppose I should rename these to something like files{modified,added,removed} since they're slightly different.</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
REPOSITORY<br>
  rHG Mercurial<br>
<br>
REVISION DETAIL<br>
  <a href="https://phab.mercurial-scm.org/D6367" rel="noreferrer noreferrer" target="_blank">https://phab.mercurial-scm.org/D6367</a><br>
<br>
To: martinvonz, #hg-reviewers<br>
Cc: yuja, mercurial-devel<br>
_______________________________________________<br>
Mercurial-devel mailing list<br>
<a href="mailto:Mercurial-devel@mercurial-scm.org" target="_blank" rel="noreferrer">Mercurial-devel@mercurial-scm.org</a><br>
<a href="https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel" rel="noreferrer noreferrer" target="_blank">https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel</a><br>
</blockquote></div></div></div>