<div dir="ltr"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 14, 2019 at 11:21 AM Raphaël Gomès <<a href="mailto:raphael.gomes@octobus.net">raphael.gomes@octobus.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF">
<p><br>
</p>
<div>On 10/14/19 7:08 PM, Gregory Szorc
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>I support marking the code base as stable with Python 3 in
the upcoming few weeks - at least for non-Windows.<br>
</div>
<div><br>
</div>
<div>If we're serious about this, we all need to be running
Mercurial with Python 3 locally and fixing bugs. I tried
installing a Python 3 Mercurial a few days ago and I
encountered enough tracebacks to cause me to revert. Those
include <a href="https://bz.mercurial-scm.org/show_bug.cgi?id=6196" rel="noreferrer" target="_blank">https://bz.mercurial-scm.org/show_bug.cgi?id=6196</a>
and an issue with evolve/obsmarkers that can be reproduced by
`hg push` to hg-committed. I think we should land a patch to
Makefile that changes <a href="https://www.mercurial-scm.org/repo/hg/file/649a9601b9e2/Makefile#l8" target="_blank">https://www.mercurial-scm.org/repo/hg/file/649a9601b9e2/Makefile#l8</a>
to `python3` to force the issue. We can revert that before
tagging 5.2 if we want to do a separate release that is Python
3 primary (there was talk of doing a 2.7 5.2 then doing a
5.2.1 or a 5.3 a week or two later that is Python 3 native).</div>
<div><br>
</div>
</div>
</blockquote>
I think this is the safer approach, regardless of progress made.<br>
<blockquote type="cite">
<div dir="ltr">
<div>We also still have a handful of test failures on Python 3.
See <a href="https://ci.hg.gregoryszorc.com/" target="_blank">https://ci.hg.gregoryszorc.com/</a>.
(CI is broken with Python 3.5 for some reason. I'll look into
it.)</div>
<div><br>
</div>
<div>Python 3 on Windows has a ton of test failures. ~120 I
believe. I suspect a lot of them are the same underlying
issues. I almost have my CI system working with Windows. But
we'll certainly need a bit of effort on Windows before we can
consider Python 3 stable there. At this time, Python 3 on
Windows seems to be at risk because of the volume of issues.<br>
</div>
<div><br>
</div>
<div>Other major blockers to Python 3 are packaging work. I'm
the de facto maintainer of the Windows packages and will write
those patches. But my priorities are standing up Windows CI
because I think having visibility into the test failures is
more important because what good is Python 3 packages if
Mercurial isn't usable :) I could also help with non-Windows
packaging if it is needed.</div>
<div><br>
</div>
<div>I would also propose we reinstate the @ code freeze for
this release so we can all focus on Python 3 and quality of
life improvements for the release. I don't think we'll put out
a quality Python 3 release if we're distracted by feature work
on @.<br>
</div>
</div>
<br>
</blockquote>
I'm not sure what you mean by "@ code freeze", can you elaborate?<br></div></blockquote><div><br></div><div>Until the past ~1 year, the policy was to have a code freeze the 2 weeks before a major release. Only patches for the stable branch / upcoming release would be accepted. We did not actively work on the @ bookmark / default branch during this freeze. The idea was that by pausing feature development we would focus on putting out a higher quality release. We changed the policy recently and now it is acceptable to send patches for @/default in the ~2 weeks before a major release.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF">
<blockquote type="cite">
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Mon, Oct 14, 2019 at 9:30
AM Pulkit Goyal <<a href="mailto:7895pulkit@gmail.com" target="_blank">7895pulkit@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hey
everyone,<br>
<br>
I hope you are doing well.<br>
<br>
We released 5.0 as beta release for Python 3 support and much
has<br>
improved since than. Evolve extension recently started
supporting<br>
Python 3. There are still few tests failing which are minor.<br>
<br>
We are planning to mark the upcoming release i.e. 5.2 as
stable<br>
release for py3 support (except Windows). If we agree on that,
we also<br>
plan to accept py3 related fixes on stable branch during
upcoming<br>
feature freeze.<br>
<br>
It will be the best time to install hg on Python 3 and start
testing.<br>
<br>
What do you think?<br>
<br>
Thanks and regards<br>
Pulkit<br>
</blockquote>
</div>
<br>
<fieldset></fieldset>
<pre>_______________________________________________
Mercurial-devel mailing list
<a href="mailto:Mercurial-devel@mercurial-scm.org" target="_blank">Mercurial-devel@mercurial-scm.org</a>
<a href="https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel" target="_blank">https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel</a>
</pre>
</blockquote>
</div>
</blockquote></div></div>