Bug 2427 - hg qrm same patch twice breaks patch queue
Summary: hg qrm same patch twice breaks patch queue
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: unspecified
Hardware: All All
: normal bug
Assignee: Dan Villiom Podlaski Christiansen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-09 09:19 UTC by Alberth
Modified: 2010-10-10 09:09 UTC (History)
2 users (show)

See Also:
Python Version: ---


Attachments
(34 bytes, application/x-sh)
2010-10-09 09:19 UTC, Alberth
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alberth 2010-10-09 09:19 UTC
When trying to remove the same patch file twice, the file gets deleted, but
not from the patch series file.
Trying to push the file (obviously) fails then.

Attached a shell script to reproduce the issue.
Output at my system:
--------------------------------------
popping add_foo
patch queue now empty

Patch queue:
add_foo

hg qrm add_foo add_foo     (notice it tries to remove 'add_foo' twice)
abort: No such file or directory:
/home/user/tmp/qrm_issue_repo/.hg/patches/add_foo

patch queue after delete:
add_foo

Files (ls -l .hg/patches)
total 4
-rw-r--r--. 1 user user 8 Oct  9 15:34 series
-rw-r--r--. 1 user user 0 Oct  9 15:34 status

No 'add_foo' patch file, while the patch queue thinks it still exists!!

Version:
Mercurial Distributed SCM (version 1.6.3)

Copyright (C) 2005-2010 Matt Mackall <mpm@selenic.com> and others
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
--------------------------------------
Comment 1 Alberth 2010-10-09 09:21 UTC
Hmm, typo, "push the file" should be "qpush the file". Sorry
Comment 2 Dan Villiom Podlaski Christiansen 2010-10-10 09:09 UTC
Fixed in 5192b24f309c.
Comment 3 Bugzilla 2012-05-12 09:13 UTC

--- Bug imported by bugzilla@serpentine.com 2012-05-12 09:13 EDT  ---

This bug was previously known as _bug_ 2427 at http://mercurial.selenic.com/bts/issue2427
Imported an attachment (id=1468)