Bug 2484 - localrepo._filecommit gets None in crev
Summary: localrepo._filecommit gets None in crev
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: unspecified
Hardware: All All
: urgent bug
Assignee: Bugzilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-10 01:20 UTC by Matt Mackall
Modified: 2012-05-13 05:05 UTC (History)
23 users (show)

See Also:
Python Version: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Mackall 2010-11-10 01:20 UTC 
A number of bug reports include this in the traceback:

  File "/usr/local/lib/python2.5/site-packages/mercurial/localrepo.py", line
761, in _filecommit
    self.ui.debug(_(" %s: copy %s:%s\n") % (fname, cfname, hex(crev)))
TypeError: b2a_hex() argument 1 must be string or read-only buffer, not None

Unifying them under this issue.
Comment 1 HG Bot 2010-11-15 18:00 UTC 
Fixed by http://selenic.com/repo/hg/rev/417f3c27983b
Matt Mackall <mpm@selenic.com>
commit: search both parents for missing copy revision (issue2484)

(please test the fix)
Comment 2 Willem Verstraeten 2010-11-16 03:21 UTC 
When I run the testcase attached to issue2038, everything seems to work OK 
with the patch, but I do get following warning :

'warning: can't find ancestor for 'dd/b' copied from 'd/b'!'

This warning only appears when rebasing a changeset onto a changeset 
containing renames, but not when rebasing a changeset containing renames onto 
a regular changeset
Comment 3 Bugzilla 2012-05-12 09:14 UTC 

--- Bug imported by bugzilla@serpentine.com 2012-05-12 09:14 EDT  ---

This bug was previously known as _bug_ 2484 at http://mercurial.selenic.com/bts/issue2484