Bug 2542 - tag should abort on uncommitted merge
Summary: tag should abort on uncommitted merge
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: unspecified
Hardware: All All
: normal bug
Assignee: Kevin Bullock
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-09 14:22 UTC by Adrian Buehlmann
Modified: 2010-12-14 19:00 UTC (History)
3 users (show)

See Also:
Python Version: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Buehlmann 2010-12-09 14:22 UTC
using 6e79a3bb8c79:

create a uncommitted merge

  $ hg init r4
  $ cd r4
  $ echo c1 > f1 
  $ hg ci -qAm0
  $ echo foo >> f1
  $ hg ci -m1
  $ hg up -q 0
  $ echo c2 > f2
  $ hg ci -qAm2
  $ hg merge
  1 files updated, 0 files merged, 0 files removed, 0 files unresolved
  (branch merge, don't forget to commit)

now, tag aborts with a silly error message

  $ hg tag t1
  abort: cannot partially commit a merge (do not specify files or patterns)
  [255]

and leaves a clobbered .hgtags file

  $ hg sta
  M f1
  A .hgtags
Comment 1 Kevin Bullock 2010-12-13 22:14 UTC
abuehl's patch tidied up and patchbombed as 
http://selenic.com/pipermail/mercurial-devel/2010-December/026914.html

Would it be poor form to assign this bug to myself, not being on crew?
Comment 2 Kevin Bullock 2010-12-13 23:16 UTC
Bumping back to in-progress since patch isn't integrated yet (per 
http://mercurial.selenic.com/wiki/ManagingBugs)
Comment 3 Adrian Buehlmann 2010-12-14 01:53 UTC
What's crew? Have fun.
Comment 4 Kevin Bullock 2010-12-14 11:39 UTC
Add topic
Comment 5 HG Bot 2010-12-14 19:00 UTC
Fixed by http://selenic.com/repo/hg/rev/ea3c93b53fdb
Kevin Bullock <kbullock@ringworld.org>
tag: fix uncommitted merge check and error message (issue2542)

(please test the fix)
Comment 6 Bugzilla 2012-05-12 09:15 UTC

--- Bug imported by bugzilla@serpentine.com 2012-05-12 09:15 EDT  ---

This bug was previously known as _bug_ 2542 at http://mercurial.selenic.com/bts/issue2542