Bug 2681 - Default failure message when unresolved files is obsolete
Summary: Default failure message when unresolved files is obsolete
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: unspecified
Hardware: All All
: normal bug
Assignee: Bugzilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-05 14:24 UTC by Antoine Pitrou
Modified: 2012-05-13 04:55 UTC (History)
4 users (show)

See Also:
Python Version: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Pitrou 2011-03-05 14:24 UTC
$ hg ci -m "Merge latest mainline changes"
abort: unresolved merge conflicts (see hg resolve)

Here, I am tempted to launch "hg resolve" as suggested by the message. But
this will actively destroy any conflict resolution I have done manually,
instead of simply listing which files I must mark resolved. This makes the
above message dangerous for the user.

I would actually advocate removing parameter-less "hg resolve", since I find
its behaviour questionable (why drop all user changes? that must be the only
hg command that destroys stuff without any specific parameter); but I guess
some people would be opposed.

But at least the message should be changed; I have been bitten more than
once and it's very painful to lose changes.
Comment 1 Antoine Pitrou 2011-03-05 15:02 UTC
Ok, I was pointed out that "hg resolve" doesn't re-merge anymore.
This simply means the message should be updated to something like "hg help
resolve".
Comment 2 Patrick Mézard 2011-03-06 13:04 UTC
Fixed in crew-stable:

  http://hg.intevation.org/mercurial/crew/rev/919174c0aaff

Thanks for reporting it
Comment 3 Bugzilla 2012-05-12 09:17 UTC

--- Bug imported by bugzilla@serpentine.com 2012-05-12 09:17 EDT  ---

This bug was previously known as _bug_ 2681 at http://mercurial.selenic.com/bts/issue2681