Bug 2687 - Built-in color extension stopped working in 1.8
Summary: Built-in color extension stopped working in 1.8
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: unspecified
Hardware: All All
: urgent bug
Assignee: Adrian Buehlmann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-10 03:32 UTC by Stephen Rank
Modified: 2011-03-14 15:00 UTC (History)
8 users (show)

See Also:
Python Version: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Rank 2011-03-10 03:32 UTC
After upgrading to Mercurial 1.8 the color extension stopped working. If I
run "hg help" it lists "color" in the "enabled extensions" section but text
is always displayed in white now. Downgrading to 1.7.5 fixes the problem.

Using Mercurial 1.8 (Inno Setup x86) on Windows 7 Professional SP1 (32-bit).
Comment 1 Pascal Quantin 2011-03-10 03:37 UTC
Hi,

the bug is due to the removal of the pywin32 package from the Inno Setup
installer. It will be fixed when Mercurial 1.8.1 is released (in a few days).
If needed, I can provide another (fixed) installer in the meantime.
Comment 2 Matt Mackall 2011-03-10 10:33 UTC
Dropping pywin32 is the right thing to do. If color depends on pywin32, then
it needs to be fixed.
Comment 3 Pascal Quantin 2011-03-10 10:36 UTC
Adding Steve who added win32 support to color extension (as far as I can
remember)
Comment 4 Steve Borho 2011-03-10 12:03 UTC
oh, nice.  This is too late for 1.8.1.  Perhaps it can be converted to ctypes 
in time for 1.8.2
Comment 5 Steve Borho 2011-03-10 12:16 UTC
As a short-term work-around, TortoiseHg still distributes pywin32 in all our 
installers because we use it internally.
Comment 6 Adrian Buehlmann 2011-03-10 12:41 UTC
Oh wow. Sorry about that bug. I didn't expect an extension would use pywin32.
Comment 7 Pascal Quantin 2011-03-10 14:49 UTC
New installers uploaded. Download links can be found on the wiki (the main
site should be updated in the next hours).
Comment 8 Benoit Boissinot 2011-03-13 05:53 UTC
Matt queued a fix two days ago.
Comment 9 HG Bot 2011-03-14 15:00 UTC
Fixed by http://selenic.com/repo/hg/rev/2420cb1ea1d6
Adrian Buehlmann <adrian@cadifra.com>
color: port to using ctypes (issue2687)

(please test the fix)
Comment 10 Bugzilla 2012-05-12 09:17 UTC

--- Bug imported by bugzilla@serpentine.com 2012-05-12 09:17 EDT  ---

This bug was previously known as _bug_ 2687 at http://mercurial.selenic.com/bts/issue2687