Bug 2698 - progress conflict with local clone -r
Summary: progress conflict with local clone -r
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: unspecified
Hardware: All All
: normal bug
Assignee: Augie Fackler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-14 14:07 UTC by Eric Eisner
Modified: 2017-10-19 00:00 UTC (History)
5 users (show)

See Also:
Python Version: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Eisner 2011-03-14 14:07 UTC
Locally cloning part of a large repo with e.g.

  $ hg clone mylocalhg hg2 -r stable

shows rapidly alternating progress bars between

  bundling [======>
  manifests [============>

Where 'bundling' intersperses itself in the changeset, manifest, and file 
progress bars.

(hg version 1bb2a56a9d73)
Comment 1 Matt Mackall 2011-05-12 17:41 UTC
I think Augie has some unsubmitted patches to fix this.
Comment 2 Augie Fackler 2011-05-14 11:17 UTC
I look at this every so often. timeless and I made a lot of progress towards 
understanding the problem, but I don't know that we came up with a compelling 
solution.
Comment 3 Matt Mackall 2011-05-14 14:22 UTC
Last I heard, there was an issue that progress bars generated in concurrent
generators were in conflict.

So we can either do:

- explicit priority
- first come, first serve
- last come, first serve

But at any rate, it seems there needs to be a global notion of "highest
priority progress bar" and other updates aren't displayed until that one is
closed.
Comment 4 Augie Fackler 2011-06-23 14:34 UTC
I've got a fix for this that I'll mail post-1.9. Sorry I got to it too late
for the 1.9 cycle.
Comment 5 HG Bot 2011-07-05 14:00 UTC
See http://selenic.com/repo/hg/rev/ec4ba216ddef
Augie Fackler <durin42@gmail.com>
progress: make progress bar a singleton to avoid double-progress ui bugs
Comment 6 Bugzilla 2012-05-12 09:18 UTC

--- Bug imported by bugzilla@serpentine.com 2012-05-12 09:18 EDT  ---

This bug was previously known as _bug_ 2698 at http://mercurial.selenic.com/bts/issue2698
Comment 7 HG Bot 2017-10-04 18:19 UTC
Fixed by https://mercurial-scm.org/repo/hg/rev/f428c347d32b
Jun Wu <quark@fb.com>
progress: remove progress.estimate config

It was introduced by 98e4d39 ("progress: add speed format" 2011-5-9) and was
intended to hide ETA information for the first few seconds.

Later 5d261fd ("progress: add a changedelay to prevent parallel topics from
flapping (issue2698)" 2011-6-23) introduced `changedelay` config which hides
the entire progress bar for the first few seconds. So `progress.estimate` seems
somehow duplicated feature-wise. Since it's experimental and duplicated, let's
just remove it. This makes the next patch simpler - it no longer needs to make
sure `starttimes` is the real start time.

Differential Revision: https://phab.mercurial-scm.org/D828

(please test the fix)
Comment 8 Bugzilla 2017-10-19 00:00 UTC
Bug was set to TESTING for 14 days, resolving