Bug 2839 - hg ident does not show "+" for modified subrepos
Summary: hg ident does not show "+" for modified subrepos
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: unspecified
Hardware: All All
: normal bug
Assignee: Bugzilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-01 06:19 UTC by Lars Povlsen
Modified: 2012-09-30 16:19 UTC (History)
5 users (show)

See Also:
Python Version: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Povlsen 2011-06-01 06:19 UTC
hg ident does not indicate modified ("+") if (just) a subrepo workdir is
changed.

This might be related to hg ident not beeing subrepo aware at all, but it
gives a false image of the workdir status.
Comment 1 kiilerix 2011-06-01 06:48 UTC
I think this is covered by
http://mercurial.selenic.com/wiki/Subrepository#Caveats "Many commands are
not aware of subrepos"
Comment 2 Kevin Bullock 2011-06-01 09:35 UTC
I'd say it's covered by the wiki, yes, but the eventual goal is to make things 
like `identify` subrepo-aware, isn't it?
Comment 3 Matt Mackall 2011-06-01 10:03 UTC
Yes. Moving this one back to bug, it'd be nice to fix this sooner rather
than later.
Comment 4 Lars Povlsen 2011-06-01 10:26 UTC
It was actually the false positive that triggered my issue report - I had a
dirty subrepo, but ident told me all was clean.

Adding a -S option could be a solution - but I guess that it should only add
the "+" value (if any subrepo was dirty - *or* any subrepo out of sync with
.hgsubstate).
Comment 5 Bugzilla 2012-05-12 09:20 UTC

--- Bug imported by bugzilla@serpentine.com 2012-05-12 09:20 EDT  ---

This bug was previously known as _bug_ 2839 at http://mercurial.selenic.com/bts/issue2839
Comment 6 Patrick Mézard 2012-07-27 08:07 UTC
Fix in crew-stable:

  http://hg.intevation.org/mercurial/crew/rev/3e856d8abe9c
Comment 7 Matt Mackall 2012-09-30 16:19 UTC
Mass close old bugs in testing.