Bug 2934 - hgwebdir and baseurl configuration regression
Summary: hgwebdir and baseurl configuration regression
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: unspecified
Hardware: All All
: normal bug
Assignee: Bugzilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-01 03:23 UTC by wujek
Modified: 2012-05-13 04:51 UTC (History)
4 users (show)

See Also:
Python Version: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description wujek 2011-08-01 03:23 UTC
Sometime after 1.7.5 (http://selenic.com/hg/rev/a35aff48d577), the hgwebdir_mod.py was changed in a way that 
it doesn't work any more if one is configuring it using the following two documents:
http://mercurial.selenic.com/wiki/HgWebDirStepByStep#Change_the_URL_using_baseurl_and_URL_rewriting
http://mercurial.selenic.com/wiki/PublishingRepositories (look for 'baseurl' in this one)

Basically, the leading slash is now always added to the  baseurl path at the beginning, which results in 
mercurial generating links with double slashes, like '//hg/static/logo.png'.

The published repositories are visible (though ugly) and can be clicked, but then all links to revisions, 
logs, and so on are also incorrect, and this time it fails big time - the interface is not usable.

Either of the two things should be done:
1. fix the code to support baseurl configs with leading slash, and add one explicitly only when it is not 
there
2. fix the documentation and tutorials how to configure it properly, preferably mentioning the versions and 
differences in these configurations that the versions introduce
Comment 1 wujek 2011-08-01 04:05 UTC
Setting as testing, as described in 
http://mercurial.selenic.com/wiki/ContributingChanges (patch sent to the 
mailing list).
Comment 2 HG Bot 2011-08-01 14:00 UTC
Fixed by http://selenic.com/repo/hg/rev/dd74cd1e5d49
wujek
hgweb: handle 'baseurl' configurations with leading slash (issue2934)

(please test the fix)
Comment 3 Bugzilla 2012-05-12 09:22 UTC

--- Bug imported by bugzilla@serpentine.com 2012-05-12 09:22 EDT  ---

This bug was previously known as _bug_ 2934 at http://mercurial.selenic.com/bts/issue2934