each largefile in the working copy is counted as an unknown file by 'hg sum', which gets confusing
Testcase patch: http://paste.pocoo.org/show/495701/
Hi Eli, It's cool to see you get involved here! Please post patches to the mailinglist -- as described here: http://mercurial.selenic.com/wiki/ContributingChanges The patch you link to is short, so I have some comments below: # HG changeset patch # User Eli Carter <eli.carter@tektronix.com> # Date 1319136187 18000 # Branch largefiles-hg-sum-bug # Node ID 684d4d39b591cf6a27c532402533d7e74700b8ba # Parent 3eb1a90ea40941ad7a920daad665e27ffdb6f291 largefiles: testcase for 'hg sum' issue 3060 => add "(issue3060)" to the summary line and a bot will notice and link back to this issue. diff -r 3eb1a90ea409 -r 684d4d39b591 tests/test-largefiles.t --- a/tests/test-largefiles.t Tue Oct 18 17:28:26 2011 -0500 +++ b/tests/test-largefiles.t Thu Oct 20 13:43:07 2011 -0500 @@ -661,6 +661,13 @@ large6-modified $ cat sub2/large7 large7 + +Verify that the largefiles are not counted as unknown files + $ hg status + $ hg sum | tail -n +3 + branch: default + commit: (clean) + update: (current) $ cd .. Verify that lfconvert adds 'largefiles' to .hg/requires => So the code actually works and you only add a test to confirm this? You'll want to address those things when you patchbomb the mailinglist.
> From: Martin Geisler [mailto:bugs@mercurial.selenic.com] > It's cool to see you get involved here! Thanks; it's cool to get some time to work on the project. > Please post patches to the mailinglist -- > as described here: > > http://mercurial.selenic.com/wiki/ContributingChanges I added it to the issue because it wasn't a patch to get reviewed or included, but rather just a testcase to demonstrate the issue. > => add "(issue3060)" to the summary line and a bot will notice and link back > to this issue. Ah, thanks for pointing that out. > Verify that lfconvert adds 'largefiles' to .hg/requires > > => So the code actually works and you only add a test to confirm this? > > You'll want to address those things when you patchbomb the mailinglist. No, this is a failing testcase to demonstrate the bug. I haven't had a chance to look into fixing it. Eli
This is a simple oversight on our part. I will fix it.
Patch submitted to Mercurial-devel list: http://www.selenic.com/pipermail/mercurial-devel/2012-January/036889.html
Fixed by http://selenic.com/repo/hg/rev/0c7b83a057aa Na'Tosha Bard <natosha@unity3d.com> largefiles: fix output of hg summary (issue3060) (please test the fix)
--- Bug imported by bugzilla@serpentine.com 2012-05-12 09:24 EDT --- This bug was previously known as _bug_ 3060 at http://mercurial.selenic.com/bts/issue3060