Bug 3285 - hgweb diff omits names of new binary files
Summary: hgweb diff omits names of new binary files
Status: RESOLVED ARCHIVED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: hgweb (show other bugs)
Version: unspecified
Hardware: All All
: normal bug
Assignee: Bugzilla
URL:
Keywords: easy
: 5167 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-02-26 18:27 UTC by Jesse Ruderman
Modified: 2017-01-28 00:00 UTC (History)
7 users (show)

See Also:
Python Version: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Ruderman 2012-02-26 18:27 UTC 
http://hg.mozilla.org/mozilla-central/rev/c1c6cd6c52b7

The contents of the binary file are shown with "new file mode 100644" but
without a filename.
Comment 1 kiilerix 2012-02-26 19:26 UTC 
Yes, that is how diffs that only can be shown with git patch format is shown
... if git format is enabled.

Same problem is seen for contrib/wix/COPYING.rtf on
http://hg.intevation.org/mercurial/crew/rev/7de7630053cb but not on
http://www.selenic.com/hg/rev/7de7630053cb

(I have unfinished patches for this somewhere.)
Comment 2 Bugzilla 2012-05-12 09:28 UTC 

--- Bug imported by bugzilla@serpentine.com 2012-05-12 09:28 EDT  ---

This bug was previously known as _bug_ 3284 at http://mercurial.selenic.com/bts/issue3284
Comment 3 kiilerix 2012-10-24 08:43 UTC 
> bos@serpentine.com 	2012-10-24 03:14:03 CEST 	Keywords easy

Actually not so easy, if I remember correctly. Especially not to do cleanly. 

Enabling git format everywhere would probably be too much of a change ... and clutter the normal output with extra lines.
Comment 4 Bugzilla 2015-02-05 01:00 UTC 
Bug was inactive for 833 days, archiving
Comment 5 Anton Shestakov 2016-04-04 21:49 UTC 
*** Bug 5167 has been marked as a duplicate of this bug. ***
Comment 6 Bugzilla 2017-01-28 00:00 UTC 
Bug was inactive for 298 days, archiving