Bug 3476 - possible performance-impeding no-op in scmutil
Summary: possible performance-impeding no-op in scmutil
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: earlier
Hardware: All All
: normal bug
Assignee: Bryan O'Sullivan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-31 02:15 UTC by Bryan O'Sullivan
Modified: 2017-11-01 18:05 UTC (History)
3 users (show)

See Also:
Python Version: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bryan O'Sullivan 2012-05-31 02:15 UTC 
Just spotted this unintentionally meaningless line:

http://selenic.com/repo/hg/file/f694ab54b660/mercurial/scmutil.py#l572

I imagine that

    seen.union(newrevs)

should be

    seen.update(newrevs)

Too late at night for me to check, hence a bug report.
Comment 1 Matt Mackall 2012-05-31 10:55 UTC 
I assume you know you put it there?
Comment 2 Bryan O'Sullivan 2012-05-31 12:07 UTC 
No, I was too tired to go digging last night. But that's kind of awesome.
Comment 3 Bryan O'Sullivan 2012-06-04 13:17 UTC 
Fix: http://selenic.com/repo/hg/rev/9da5a2864f3f
Comment 4 Matt Mackall 2012-07-29 14:52 UTC 
Fixed in 2.2.3 by:

9da5a2864f3f scmutil: seen.union should be seen.update