Bug 3698 - commit --amend --logfile prompts for interactive editor
Summary: commit --amend --logfile prompts for interactive editor
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: earlier
Hardware: Macintosh Mac OS
: urgent bug
Assignee: Bugzilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-12 20:05 UTC by marcos ojeda
Modified: 2017-11-01 18:05 UTC (History)
4 users (show)

See Also:
Python Version: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description marcos ojeda 2012-11-12 20:05 UTC 
possibly related to bug 3675, but in 2.4 running 

    hg commit --amend --logfile somefile

pops open an interactive editor rather than accepting somefile as the new commit message (as in 2.3)
Comment 1 Matt Mackall 2012-11-13 01:44 UTC 
Confirmed. I don't think this is intentional. Regression -> upgrading to urgent.
Comment 2 Pierre-Yves David 2012-11-13 06:03 UTC 
Also affect --message too. I'm currently texting a fix.
Comment 3 HG Bot 2012-11-15 17:15 UTC 
Fixed by http://selenic.com/repo/hg/rev/45bd0cd7ca04
Pierre-Yves David <pierre-yves.david@logilab.fr>
amend: force editor only if old message is reused (issue3698)

This regression was added by 9732473aa24b. It triggered the editor even if
--message or --logfile were provided.

(please test the fix)