Bug 3759 - hg commit -S -A does not commit subrepos when they only contain files with ? and ! status
Summary: hg commit -S -A does not commit subrepos when they only contain files with ? ...
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: earlier
Hardware: All All
: normal bug
Assignee: Bugzilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-09 08:49 UTC by raphael
Modified: 2017-11-01 18:05 UTC (History)
2 users (show)

See Also:
Python Version: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description raphael 2013-01-09 08:49 UTC 
Per the summary, hg ci -S -A performs a subrepo commit only when a subrepo contains a  modified file (hg st -S sees the subrepo changes just fine, so this is an unexpected discrepancy).
Comment 1 Matt Mackall 2013-01-09 13:38 UTC 
I assume you mean the subrepo contains files in state "?" (unknown) or "!" (deleted), not "A" (added) or "R" (removed).

I don't think -A is propagated to subrepos.
Comment 2 raphael 2013-01-09 16:57 UTC 
(In reply to comment #1)
Yes. Summary touched up accordingly. I think the -A should propagate to subrepos.
Comment 3 HG Bot 2014-12-12 16:47 UTC 
Fixed by http://selenic.com/repo/hg/rev/f1b06a8aad42
Matt Harbison <matt_harbison@yahoo.com>
commit: propagate --addremove to subrepos if -S is specified (issue3759)

The recursive addremove operation occurs completely before the first subrepo is
committed.  Only hg subrepos support the addremove operation at the moment- svn
and git subrepos will warn and abort the commit.

(please test the fix)
Comment 4 Matt Mackall 2015-01-22 15:04 UTC 
Bulk testing -> fixed