Bug 3810 - hgweb summary breaks with secret changesets
Summary: hgweb summary breaks with secret changesets
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: hgweb (show other bugs)
Version: earlier
Hardware: PC Windows
: normal bug
Assignee: Bugzilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-05 10:22 UTC by Kevin Bullock
Modified: 2017-11-01 18:05 UTC (History)
4 users (show)

See Also:
Python Version: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Bullock 2013-02-05 10:22 UTC
Originally reported in bug #3783, comment #6:

Ruslan Yushchenko 2013-02-05 06:03:10 UTC
Mercurial 2.5, Windows XP 32 bit. Now crashes on "Summary" tab:

127.0.0.1 - - [05/Feb/2013 12:50:31] Exception happened during processing request '/summary':
Traceback (most recent call last):
  File "mercurial\hgweb\server.pyc", line 77, in do_POST
  File "mercurial\hgweb\server.pyc", line 70, in do_write
  File "mercurial\hgweb\server.pyc", line 137, in do_hgweb
  File "mercurial\util.pyc", line 327, in increasingchunks
  File "mercurial\templater.pyc", line 315, in _flatten
  File "mercurial\templater.pyc", line 308, in _flatten
  File "mercurial\hgweb\webcommands.pyc", line 522, in changelist
  File "mercurial\localrepo.pyc", line 385, in __getitem__
  File "mercurial\context.pyc", line 33, in __init__
RepoLookupError: unknown revision '20'

('20' is a secret revision)
Comment 1 HG Bot 2013-02-07 07:45 UTC
Fixed by http://selenic.com/repo/hg/rev/6d098adc5a46
Kevin Bullock <kbullock@ringworld.org>
hgweb: make 'summary' work with hidden changesets (issue3810)

Since the 'summary' view used by e.g. gitweb and monoblue shows both a
changelog and a bookmarks list, the same changes are needed here as were
made to the 'changelog' and 'bookmarks' web commands (56ca4443a343 and
886936ecc21b, respectively).

(please test the fix)
Comment 2 Kevin Bullock 2013-04-28 23:08 UTC
Fix went out with 2.5.1, closing.