Bug 3891 - hg rebase complains about phases on no-op
Summary: hg rebase complains about phases on no-op
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: rebase (show other bugs)
Version: earlier
Hardware: PC Linux
: normal bug
Assignee: Siddharth Agarwal
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2013-04-17 14:34 UTC by Matt Mackall
Modified: 2017-11-01 18:04 UTC (History)
4 users (show)

See Also:
Python Version: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Mackall 2013-04-17 14:34 UTC
Make a trivial repo:

    $ hg init blah
    $ cd blah
    $ echo a > a
    $ hg ci -Am0
    adding a
    $ echo b > a
    $ hg ci -m1

Do a no-op rebase:

    $ hg rebase -s 1 -d 0
    nothing to rebase

Do it again after making everything public:

    $ hg phase --public -r 0:
    $ hg rebase -s 1 -d 0
    abort: can't rebase immutable changeset 292174bf9db9
    (see hg help phases for details)

The latter error message is alarming. It should be the same as the first.
Comment 1 HG Bot 2013-04-18 18:45 UTC
Fixed by http://selenic.com/repo/hg/rev/53eadcb814fd
Siddharth Agarwal <sid0@fb.com>
rebase: check no-op before checking phase (issue3891)

This could lead to user confusion, because phases aren't really involved at
all when attempting to perform a no-op rebase.

(please test the fix)