Bug 4091 - Response does not finish when "revcount" is non numeric
Summary: Response does not finish when "revcount" is non numeric
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: hgweb (show other bugs)
Version: 2.8
Hardware: PC Linux
: normal bug
Assignee: Bugzilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-08 03:47 UTC by IsaacJurado
Modified: 2014-01-06 10:48 UTC (History)
2 users (show)

See Also:
Python Version: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description IsaacJurado 2013-11-08 03:47 UTC 
Some hgweb commands accept a "revcount" parameter to indicate the amount of changesets to show per page.  The value in this parameter is expected to be an integer.  But if the value cannot be parsed, the exception is not handled properly and the response does not finish until the server timeout is enforced (which may be infinite).
Comment 1 HG Bot 2013-11-22 18:30 UTC 
Fixed by http://selenic.com/repo/hg/rev/77acd8ce01ce
Isaac Jurado <diptongo@gmail.com>
hgweb: ignore non numeric "revcount" parameter values (issue4091)

(please test the fix)