Bug 4101 - hg view tags only show last word in tag
Summary: hg view tags only show last word in tag
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: 2.8
Hardware: PC Linux
: wish bug
Assignee: Bugzilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-17 06:51 UTC by Javi
Modified: 2014-01-06 10:44 UTC (History)
4 users (show)

See Also:
Python Version: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Javi 2013-11-17 06:51 UTC

    
Comment 1 Javi 2013-11-17 06:55 UTC
D Haley reports in the Debian BTS[0]:

The following sequence of commands can produce a bug whereby a tag, such as "release version" will instead only show "version" in the tag view. This appears to be a regression, as this previously worked in earlier versions of hg view.

Here is a sesion reproducing the bug:

$ hg init f
$ cd f
$ echo a > file
$ hg add file
$ hg commit -u "me" -m "commitMesg"
$ echo "otherstuff" > file
$ hg commit -u "me" -m "yacm"
$ hg tag -u me -r 1 -m "commit tag" "Some Tag Here"
$ hg --config extensions.hgk= view

Instead of "Some Tag Here", i simply see "Here" in the tree display. The contents of .hgtags appears to be correct, and so does the output from hg tags.

I think *maybe* that it might be related to this change. Ive rarely used tcl.:
http://www.selenic.com/pipermail/mercurial-devel/2013-March/049582.html

[0] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=725904
Comment 2 Kevin Bullock 2013-11-17 10:39 UTC
hgview is a separate project whose bug tracker lives here: <https://www.logilab.org/project/hgview>.
Comment 3 Javi 2013-11-17 11:04 UTC
This is not hgview, it's "hg view".  It's part of hgk, which is shipped with mercurial.
Comment 4 Matt Mackall 2013-11-17 11:25 UTC
Setting this to confirmed. Also setting it to wish:

http://mercurial.selenic.com/wiki/UnlovedFeatures
Comment 5 Andrew Shadura 2013-11-29 08:45 UTC
I've prepared a patch fixing this issue; sending it in a moment.
Comment 6 HG Bot 2013-12-01 15:15 UTC
Fixed by http://selenic.com/repo/hg/rev/970394b6bd97
Andrew Shadura <andrew@shadura.me>
hgk: fix tag list parser (issue4101)

As tags may have embedded spaces, and "hg tags" command doesn't escape them,
the output of the command doesn't make a well-formed list, so we can't just
iterate over it. Instead, apply a simple regexp to transform it to a list
which we actually use. Line boundary matching should be enabled.

(please test the fix)