Bug 4362 - {extras % ' Extra:{extra}'} template doesn't work
Summary: {extras % ' Extra:{extra}'} template doesn't work
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: 3.1.1
Hardware: All All
: wish feature
Assignee: Bugzilla
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2014-09-08 20:23 UTC by Durham Goode
Modified: 2015-01-22 15:04 UTC (History)
4 users (show)

See Also:
Python Version: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Durham Goode 2014-09-08 20:23 UTC
The "{extras % ' Extra:{extra}'}" template doesn't print all the extras.  It just prints the first one N times (where N is the number of extras).

~/myrepo> hg log -r . --template "{files % ' File:{file}\n'}"
 File:README.txt
 File:bar.txt
~/myrepo> hg log -r . --template "{extras % ' Extra:{extra}\n'}"
 Extra:amend_source=4ff5239a93b636057ca86a79063df19b05592cb7
 Extra:amend_source=4ff5239a93b636057ca86a79063df19b05592cb7
 Extra:amend_source=4ff5239a93b636057ca86a79063df19b05592cb7
Comment 1 Augie Fackler 2014-09-09 11:40 UTC
I've seen this out of the templater too.
Comment 2 FUJIWARA Katsunori 2014-09-09 12:30 UTC
You can format each extra values by "{key}" and "{value}" in map
operation.

  $ hg log -r REV --template "{extras % '{key} => {value}\n'}"

IMHO, help document of "extras" template keyword should be
improved :-)
Comment 3 HG Bot 2014-11-04 17:46 UTC
Fixed by http://selenic.com/repo/hg/rev/a3c2d9211294
Matt Harbison <matt_harbison@yahoo.com>
templater: don't overwrite the keyword mapping in runsymbol() (issue4362)

This keyword remapping was introduced in e06e9fd2d99f as part of converting
generator based iterators into list based iterators, mentioning "undesired
behavior in template" when a generator is exhausted, but doesn't say what and
introduces no tests.

The problem with the remapping was that it corrupted the output for keywords
like 'extras', 'file_copies' and 'file_copies_switch' in templates such as:

    $ hg log -r 142b5d5ec9cc --template "{file_copies % ' File: {file_copy}\n'}"
    File: mercurial/changelog.py (mercurial/hg.py)
    File: mercurial/changelog.py (mercurial/hg.py)
    File: mercurial/changelog.py (mercurial/hg.py)
    File: mercurial/changelog.py (mercurial/hg.py)
    File: mercurial/changelog.py (mercurial/hg.py)
    File: mercurial/changelog.py (mercurial/hg.py)
    File: mercurial/changelog.py (mercurial/hg.py)
    File: mercurial/changelog.py (mercurial/hg.py)

What was happening was that in the first call to runtemplate() inside runmap(),
'lm' mapped the keyword (e.g. file_copies) to the appropriate showxxx() method.
On each subsequent call to runtemplate() in that loop however, the keyword was
mapped to a list of the first item's pieces, e.g.:

   'file_copy': ['mercurial/changelog.py', ' (', 'mercurial/hg.py', ')']

Therefore, the dict for the second and any subsequent items were not processed
through the corresponding showxxx() method, and the first item's data was
reused.

The 'extras' keyword regressed in de7e6c489412, and 'file_copies' regressed in
0b241d7a8c62 for other reasons.  The common thread of things fixed by this seems
to be when a list of dicts are passed to the templatekw._hybrid class.

(please test the fix)
Comment 4 Matt Mackall 2015-01-22 15:04 UTC
Bulk testing -> fixed