Bug 4430 - streaming clone does not copy bookmarks
Summary: streaming clone does not copy bookmarks
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: 3.2-rc
Hardware: PC Mac OS
: urgent bug
Assignee: Bugzilla
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2014-10-31 15:27 UTC by Durham Goode
Modified: 2015-01-22 15:04 UTC (History)
3 users (show)

See Also:
Python Version: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Durham Goode 2014-10-31 15:27 UTC 
hg init foo
cd foo
touch a
hg commit -Aqm a
hg book foo
cd ..
hg clone --uncompressed ssh://localhost/.../foo bar
cd bar
hg book

Expected: you see the bookmarks
Actual: there are no bookmarks

Looks like this is due to the bookmark logic being moved into exchange.py
Comment 1 Pierre-Yves David 2014-10-31 15:40 UTC 
marking as regression (and urgent)
Comment 2 HG Bot 2014-10-31 17:00 UTC 
Fixed by http://selenic.com/repo/hg/rev/2dc6b7917cdf
Durham Goode <durham@fb.com>
clone: fix copying bookmarks in uncompressed clones (issue4430)

ef62c66bee1b broke bookmarks getting copied during uncompressed clones. Since
most of the pull logic has been moved into exchange.py, lets just call
exchange.pull to fix up the repo with the latest bits after the streaming clone
has bootstrapped the repo. This keeps us from having to duplicate the bookmark
logic.

(please test the fix)
Comment 3 mf 2014-11-01 18:04 UTC 
Tested. Bookmarks that previously were not cloned now appear to be cloned correctly.
Comment 4 Matt Mackall 2015-01-22 15:04 UTC 
Bulk testing -> fixed