Bug 4491 - hg config -g crash on windows
Summary: hg config -g crash on windows
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: 3.2.4
Hardware: PC Windows
: normal bug
Assignee: Bugzilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-06 07:34 UTC by kiilerix
Modified: 2015-10-26 00:00 UTC (History)
3 users (show)

See Also:
Python Version: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description kiilerix 2015-01-06 07:34 UTC 
scmwindows.systemrcpath can return [], causing crash in paths[0] when trying to create a new global config file.

The output from   hg config --debug   is also not as helpful on windows as it  is on posix where it shows non-existing files it would like to read (such as /etc/mercurial/hgrc).

I guess the best solution is to redefine the the exact semantics on windows and let it read all the global config files - not just the first one. The documentation already seems to suggest that.
Comment 1 Matt Mackall 2015-01-06 13:59 UTC 
Confirming first clause of this, we'll pretend submitter didn't mention the second in the same issue.
Comment 2 kiilerix 2015-01-06 14:16 UTC 
Both clauses have the same root cause: scmwindows.systemrcpath can return [].
Comment 3 Bugzilla 2015-07-06 00:00 UTC 
Bug was inactive for 180 days, archiving
Comment 4 Pierre-Yves David 2015-07-06 01:25 UTC 
kiilerix: was this fixed?
Comment 5 Matt Mackall 2015-10-18 15:16 UTC 
Fixed by:

changeset:   31300:adae8928fe09
user:        Mads Kiilerich <madski@unity3d.com>
date:        Mon Oct 12 20:13:12 2015 +0200
summary:     windows: read all global config files, not just the first (issue4491) (BC)
Comment 6 Bugzilla 2015-10-26 00:00 UTC 
Bug was set to TESTING for 7 days, resolving