Bug 5733 - test-convert-bzr-directories.t fails with older bzr
Summary: test-convert-bzr-directories.t fails with older bzr
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: convert (show other bugs)
Version: 4.4
Hardware: PC All
: wish bug
Assignee: Bugzilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-04 11:59 UTC by Matt Harbison
Modified: 2017-12-12 00:00 UTC (History)
4 users (show)

See Also:
Python Version: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Harbison 2017-11-04 11:59 UTC 
Originally reported by timeless[1], but I ran into this myself a few months ago on CentOS 7 with the distro package for bzr and a source build of a newer hg.  I tracked it to this change:

changeset:   32495:a234b32b744a
branch:      stable
parent:      32493:334632380e22
user:        Kevin Bullock <kbullock+mercurial@ringworld.org>
date:        Tue Jul 19 11:00:32 2016 -0500
summary:     convert: update use of deprecated bzrlib property

So I figured my mistake was not updating bzr as well.

[1] https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-November/107332.html
Comment 1 Kevin Bullock 2017-11-04 20:39 UTC 
Given that (apparently) some distros are still distributing old versions of bzr, it may be worth it to help people convert off of it without upgrading. I'm lowering the priority to 'wish' though.
Comment 2 HG Bot 2017-12-04 11:30 UTC 
Fixed by https://mercurial-scm.org/repo/hg/rev/759234670d19
Matt Harbison <matt_harbison@yahoo.com>
convert: restore the ability to use bzr < 2.6.0 (issue5733)

This effectively conditionalizes a234b32b744a.  Some Linux distributions (like
CentOS 7) use really old versions, and the change referenced was causing
exceptions to be thrown.

Even though the deprecation warning says 'since 2.5.0', it wasn't marked as such
in 2.5.1, but is by 2.6.0.  This was tested with 2.4.2 and 2.6.0 with
PYTHONWARNINGS=::DeprecationWarning, and both paths were exercized.

(please test the fix)
Comment 3 Bugzilla 2017-12-12 00:00 UTC 
Bug was set to TESTING for 7 days, resolving