Bug 5775 - relnotes extension choked on two revisions in the 4.5 development cycle
Summary: relnotes extension choked on two revisions in the 4.5 development cycle
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: default branch
Hardware: All All
: wish bug
Assignee: Bugzilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-22 18:29 UTC by Augie Fackler
Modified: 2018-03-17 00:00 UTC (History)
2 users (show)

See Also:
Python Version: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Augie Fackler 2018-01-22 18:29 UTC
da91e7309daf8ffc51bf3e6f4b2d8a16ef5af95a and 3398603c5621b52dcd6b4c31444635a6979d561d both break the relnotes extension hard enough it gave up on giving me release notes and I had to exclude them. Two things come to mind:

1) The abort should mention which changeset caused problems when it gives up

2) We should try to do better about not giving up


For bonus points, we could add a hasrelnotes() revset so that revisions with no relnotes can be selected for later analysis? I'm not sure if that's a good idea tho.
Comment 1 HG Bot 2018-03-09 08:20 UTC
Fixed by https://mercurial-scm.org/repo/hg/rev/658ed9c7442b
Rishabh Madan <rishabhmadan96@gmail.com>
releasenotes: replace abort with warning while parsing (issue5775)

During the 4.5 development cycle, the extension broke on two different changesets.
This fixes the issue by ensuring that it just throws a warning when it encounters
unexpected behaviour, instead of aborting.

Differential Revision: https://phab.mercurial-scm.org/D2255

(please test the fix)
Comment 2 Bugzilla 2018-03-17 00:00 UTC
Bug was set to TESTING for 7 days, resolving