Bug 5821 - conflict between evolve and notify, cannot push hidden extension.
Summary: conflict between evolve and notify, cannot push hidden extension.
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: evolution (show other bugs)
Version: earlier
Hardware: PC Linux
: wish feature
Assignee: Bugzilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-15 14:21 UTC by Uwe Brauer
Modified: 2018-04-27 00:00 UTC (History)
2 users (show)

See Also:
Python Version: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Uwe Brauer 2018-03-15 14:21 UTC
Hi

I am running:
mercurial 4.4.1 on Ubuntu 16.04,
I installed evolve via pip
and notify.


[hooks]
incoming.notify = python:hgext.notify.hook
outgoing.notify = python:hgext.notify.hook


I just run

hg commit --amend -m "Remove user from subscribe list (notify)"

And then 

hg push

pushing to https://kalthad@bitbucket.org/kalthad/hgedo
searching for changes
error: outgoing.notify hook raised an exception: hidden revision '81'
(run with --traceback for stack trace)

Then I run

hg push --traceback
pushing to https://kalthad@bitbucket.org/kalthad/hgedo
searching for changes
no changes found


So I am confused. I cloned the repo and everything seems ok. Revision 81
is not on bitbucket

Any comments?

Uwe Brauer
Comment 1 Bugzilla 2018-04-15 00:00 UTC
Bug was set to UNCONFIRMED for 30 days, bumping
Comment 2 HG Bot 2018-04-19 20:25 UTC
Fixed by https://mercurial-scm.org/repo/hg/rev/a07fab68621f
Boris Feld <boris.feld@octobus.net>
notify: use changelog API to iterate over revision number (issue5821)

This will avoid iterating over filtered revision.

(please test the fix)
Comment 3 HG Bot 2018-04-19 20:25 UTC
Fixed by https://mercurial-scm.org/repo/hg/rev/04d648b53e3e
Boris Feld <boris.feld@octobus.net>
notify: access the initial revision on an unfiltered repository (issue5821)

This should avoid crash when the first revision pushed end up being hidden.

(please test the fix)
Comment 4 HG Bot 2018-04-19 20:25 UTC
Fixed by https://mercurial-scm.org/repo/hg/rev/68748c2c761b
Boris Feld <boris.feld@octobus.net>
notify: only notify for non-filtered revision

This should fix issue5821 for hook targeting individual revision.

(please test the fix)
Comment 5 Bugzilla 2018-04-27 00:00 UTC
Bug was set to TESTING for 7 days, resolving