Bug 5924 - 'hg verify' output is a bit confusing
Summary: 'hg verify' output is a bit confusing
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: stable branch
Hardware: PC Other
: wish bug
Assignee: Bugzilla
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2018-06-20 13:18 UTC by Josef "Jeff" Sipek
Modified: 2018-09-19 00:00 UTC (History)
3 users (show)

See Also:
Python Version: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Josef "Jeff" Sipek 2018-06-20 13:18 UTC
Just run 'hg verify' on any repo:

$ hg verify
checking changesets
checking manifests
crosschecking files in changesets and manifests
checking files
500 files, 2035 changesets, 2622 total revisions

The last line is a bit confusing since to most users the terms "revision", "changeset", and "commit" are interchangeable.

I'm guessing that "revisions" here has something to do with revlog entries instead of commits - which are labeled as "changesets" in the output.  Sadly, I don't have a good suggestion for a replacement term.



$ hg version -v
Mercurial Distributed SCM (version 4.6.1+9-ae7f27867c2a)
(see https://mercurial-scm.org for more information)

Copyright (C) 2005-2018 Matt Mackall and others
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Enabled extensions:

  hgk        internal  
  graphlog   internal  
  purge      internal  
  gpg        internal  
  churn      internal  
  pager      internal  
  shelve     internal  
  histedit   internal  
  rebase     internal  
  patchbomb  internal  
  githelp    internal  
  evolve     external  8.0.1
  topic      external  0.9.1
Comment 1 Yuya Nishihara 2018-06-28 07:07 UTC
It's file revisions.
Comment 2 Josef "Jeff" Sipek 2018-06-28 08:41 UTC
From IRC a few days ago:

<martinvonz> jeffpc: maybe "file revisions"?
<jeffpc> what does 'hg pull' call it?
<martinvonz> the number is just about number of file revisions, not including changesets (obviously, since it's barely larger in your case)
<martinvonz> pull calls it "changes"
<martinvonz> i'm not sure if that's the same thing
<jeffpc> "file revisions" sounds better than "revisions", IMO
<martinvonz> seems to be the same, actually
<jeffpc> I'd be ok with "changes"; users will be used to that term
<martinvonz> so "500 files, 2035 changesets, 2622 total revisions" => "2035 changesets, 2622 changes to 500 files"?
<martinvonz> sorry, "checked 2035 changesets with 2622 changes to 500 files" to match it exactly (besides s/added/checked/)
<jeffpc> yeah
<martinvonz> btw, i looked into these things a few years ago. my issue was that manifest revisions are not mentioned. it rarely matters since they're pretty much 1:1 with changesets, but with tree manifests, that's no longer the case
Comment 3 Pulkit Goyal 2018-07-03 09:04 UTC
The "checked 2035 changesets with 2622 changes to 500 files" idea looks good to me. This will require changing the output format somewhere in this class https://www.mercurial-scm.org/repo/hg/file/tip/mercurial/verify.py#l37.

I will be happy to mentor to fix this bug. I am pulkit on #mercurial, ping me if you need help.
Comment 4 HG Bot 2018-09-11 16:50 UTC
Fixed by https://mercurial-scm.org/repo/hg/rev/f1186c292d03
Meirambek Omyrzak <meirambek77@gmail.com>
verify: make output less confusing (issue5924)

output before: "500 files, 2035 changesets, 2622 total revisions"
output after: "checked 2035 changesets with 2622 changes to 500 files"

new one was suggested in the comments inside the issue.

Differential Revision: https://phab.mercurial-scm.org/D4476

(please test the fix)
Comment 5 Bugzilla 2018-09-19 00:00 UTC
Bug was set to TESTING for 7 days, resolving