Bug 6003 - statprof.py no longer gather results
Summary: statprof.py no longer gather results
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: default branch
Hardware: PC Linux
: urgent bug
Assignee: Bugzilla
URL:
Keywords: regression, releaseblocker
Depends on:
Blocks:
 
Reported: 2018-10-17 08:54 UTC by Boris Feld
Modified: 2018-10-30 00:00 UTC (History)
3 users (show)

See Also:
Python Version: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Feld 2018-10-17 08:54 UTC 
After changeset 2864f8d3fcd6, hg --profile no longer display any output. Digging a bit, it seems to not gather any data during the run.
Comment 1 Gregory Szorc 2018-10-17 09:19 UTC 
Lol.

This is what happens when you blindly trust tests [that apparently filter out all output that verifies the profiler actually works).
Comment 2 HG Bot 2018-10-22 12:05 UTC 
Fixed by https://mercurial-scm.org/repo/hg/rev/1ce4fe0603a6
Pulkit Goyal <pulkit@yandex-team.ru>
test: show more profile lines in test-profile.t

This shows that we don't output anything after the first line and demonstrate
issue6003.

Differential Revision: https://phab.mercurial-scm.org/D5171

(please test the fix)
Comment 3 HG Bot 2018-10-22 12:05 UTC 
Fixed by https://mercurial-scm.org/repo/hg/rev/4613f9274fc0
Pulkit Goyal <pulkit@yandex-team.ru>
statprof: update the name as the i increases (issue6003)

2864f8d3fcd6 while working on py3 fix, take out the name building out of the
loop so we were not building the new stack-name for each i, rather we were using
the first one again and again.

The test changes shows the profile is now working.

Differential Revision: https://phab.mercurial-scm.org/D5172

(please test the fix)
Comment 4 Bugzilla 2018-10-30 00:00 UTC 
Bug was set to TESTING for 7 days, resolving