Bug 6018 - revset bookmark('re:nonexistent') aborts
Summary: revset bookmark('re:nonexistent') aborts
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: bookmarks (show other bugs)
Version: 4.8
Hardware: PC Linux
: wish bug
Assignee: Bugzilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-05 11:28 UTC by Martin von Zweigbergk
Modified: 2018-11-17 00:01 UTC (History)
2 users (show)

See Also:
Python Version: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin von Zweigbergk 2018-11-05 11:28 UTC 
$ hg log -r "bookmark('re:nonexistent')"
abort: no bookmarks exist that match 'nonexistent'!

It seems like it should simply return an empty set. That's what tag('re:nonexistent') does.
Comment 1 Yuya Nishihara 2018-11-06 06:42 UTC 
Nods.
Comment 2 HG Bot 2018-11-09 22:36 UTC 
Fixed by https://mercurial-scm.org/repo/hg/rev/7ed611c60168
Martin von Zweigbergk <martinvonz@google.com>
revsets: make bookmark/named('re:nonexistent') not abort (issue6018) (BC)

Foozy documented the differences between revsets branch(), tag(),
bookmark(), and named() in eeb5d5ab14a6 (revset: raise RepoLookupError
to make present() predicate continue the query, 2015-01-31). He seemed
to want tag() to change behavior to not error out on non-matching
regular expressions. I think it's instead bookmark() and named() that
should not error out. So that's what this patch does.

Differential Revision: https://phab.mercurial-scm.org/D5220

(please test the fix)
Comment 3 Bugzilla 2018-11-17 00:01 UTC 
Bug was set to TESTING for 7 days, resolving