Bug 6237 - test-clone-uncompressed.t race condition
Summary: test-clone-uncompressed.t race condition
Status: RESOLVED FIXED
Alias: None
Product: Mercurial
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: 5.2rc0
Hardware: PC Linux
: wish feature
Assignee: Julien Cristau
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-07 04:41 UTC by Julien Cristau
Modified: 2020-07-21 00:00 UTC (History)
2 users (show)

See Also:
Python Version: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Cristau 2019-12-07 04:41 UTC
I got a test-clone-uncompressed.t failure:

--- /<<PKGBUILDDIR>>/tests/test-clone-uncompressed.t
+++ /<<PKGBUILDDIR>>/tests/test-clone-uncompressed.t#stream-bundle2.err
@@ -404,6 +404,8 @@
   $ echo >> repo/f1
   $ echo >> repo/f2
   $ hg -R repo ci -m "1"
+  waiting for lock on repository repo held by process '31769' on host 'mipsel-aql-01/effffffc'
+  got lock after 1 seconds
   $ wait
   $ hg -R clone id
   000000000000

I guess that's what the "sleep 1" in there is meant to avoid, but it's not too reliable.

Full log:
https://buildd.debian.org/status/fetch.php?pkg=mercurial&arch=mipsel&ver=5.2.1-1&stamp=1575682754&raw=0
Comment 1 Bugzilla 2020-01-07 00:02 UTC
Bug was set to UNCONFIRMED for 31 days, bumping
Comment 2 Bugzilla 2020-02-07 00:02 UTC
Bug was set to UNCONFIRMED for 30 days, bumping
Comment 3 Bugzilla 2020-03-08 00:01 UTC
Bug was set to UNCONFIRMED for 30 days, bumping
Comment 4 Pierre-Yves David 2020-03-19 21:00 UTC
The logs shows it
Comment 5 Julien Cristau 2020-06-26 04:46 UTC
https://phab.mercurial-scm.org/D8664
Comment 6 HG Bot 2020-06-29 14:55 UTC
Fixed by https://mercurial-scm.org/repo/hg/rev/752da6863e39
Julien Cristau <jcristau@debian.org>
test: redirect stderr so warning messages don't change output (issue6237)

clone and commit race for the lock, and if commit has to wait more than
a second it prints a warning to stderr.  Since this is somewhat expected
here, silence it.

Differential Revision: https://phab.mercurial-scm.org/D8664

(please test the fix)
Comment 7 Bugzilla 2020-07-07 00:01 UTC
Bug was set to TESTING for 7 days, resolving
Comment 8 HG Bot 2020-07-13 13:00 UTC
Fixed by https://mercurial-scm.org/repo/hg/rev/23119371df5e
Pierre-Yves David <pierre-yves.david@octobus.net>
test-clone-uncompressed: use config to silence the lock warning

The ui.timeout.warn option can solve the issue6237 in a cleaner way than what
was done in 752da6863e39. That way, possible other unexpected error output will
not be silenced.

Differential Revision: https://phab.mercurial-scm.org/D8726

(please test the fix)
Comment 9 Bugzilla 2020-07-21 00:00 UTC
Bug was set to TESTING for 7 days, resolving