Win32 Command Quoting
pmezard at gmail.com
Fri Dec 15 13:10:23 CST 2006
[Sorry if you receive this message twice, it seems I have problems
mailing to the devel list].
I have run into shell command quoting issues with extdiff under win32
and wrote a patch to fix it at ui.system() level. Should I post it or
are there any reasons preventing such a thing to be brought into main
until now ?
I am asking this because I have seen at least one similar effort to be
ignored or rejected in the past. It was a bit different because the
patch was applied at extension level instead of system() call but the
roots were clearly identified
What I did is to detect the case where the Win32 shell behaves
differently and add extra quotes to prevent it, before calling system().
The main drawback of this approach is it would break code already
working around this issue at extension level.
What do you think about it ?
More information about the Mercurial-devel