convert_svn ("release early" edition)

[Matt Mackall]

On Fri, Apr 06, 2007 at 03:20:03PM -0400, Daniel Holth wrote:
> Sorry, I have only pushed Shun-ichi's patch into my patch queue
> repository
> (http://dingoskidneys.com/cgi-bin/hgwebdir.cgi/queue-convert-svn/). I
> don't have a patch for one-revision-repositories. It's not very
> important to me because it's easy to preserve one revision of history
> without special tools. This queue applies cleanly on top of
> http://www.selenic.com/repo/hg tip as of now.

Taking a peek at this, some comments:

interface:

 Actually making your convert_whatever a base class for the other
 classes is probably worth doing. Call it class converter.

transport:

 This could stand to get stripped down even more.

tzinfo:

 What's this for, exactly? This probably wants to be replaced with
 util.parsedate.

convert_svn:

 We probably shouldn't try to import all the SVN modules unless we're
 actually doing an SVN conversion. And then they should be wrapped in
 try/except. recode() ought to be made global. Otherwise it looks
 pretty reasonable.

-- 
Mathematics is the supreme nostalgia of our time.