[PATCH 1 of 2] Fix hgwebdir after 9858477ed74cce9dc8f4069f9453a1bda0e13ba1 broke it

Eric M. Hopper hopper at omnifarious.org
Tue Aug 7 00:22:39 CDT 2007

On Mon, 2007-08-06 at 23:43 +0200, Benoit Boissinot wrote:
> On 8/6/07, Eric Hopper <hopper at omnifarious.org> wrote:
> > 2 files changed, 24 insertions(+), 8 deletions(-)
> > mercurial/commands.py     |    2 +-
> > mercurial/hgweb/server.py |   30 +++++++++++++++++++++++-------
> >
> >
> Why not use this simpler patch ?

Because in most cases the config entries you really want are in the
webdir config even when you have a repo available.  You basically want
the repo to override the webdir settings if it has any config entries
that would.

So, unless there's a way to combine the config entries from two ui
instances in a clean way, this is what I choose.

Anyway, I'm tired of spending hours and hours fiddling every patch I
submit.  Especially when I'm fixing some bug introduced by another patch
that likely didn't get enough review.  (Why does the code in a
particular function both check to see if the repo is not None and also
act like the repo can never be None?)  The last time I tried to submit
patches I spent at least 6 times as long revising patches and sending
them in than I did creating them in the first place.  I would've done
better just maintaining the branches on my own and not submitting
anything.  I have a whole ton of other changes I've made where I've done
just that because it's not worth it.

A word is nothing more or less than the series of historical
connotations given to it. That's HOW we derive meaning, and to claim
that there is an arbitrary meaning of words above and beyond the way
people use them is a blatant misunderstanding of the nature of language.
-- Anonymous blogger
-- Eric Hopper - http://www.omnifarious.org/~hopper/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 185 bytes
Desc: This is a digitally signed message part
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20070806/77f1ac20/attachment.pgp 

More information about the Mercurial-devel mailing list