[PATCH 2 of 2] Fix income/pull with bundle and -R (issue 820)

Peter Arrenbrecht peter.arrenbrecht at gmail.com
Tue Dec 4 02:06:37 CST 2007


On Dec 4, 2007 8:51 AM, Matt Mackall <mpm at selenic.com> wrote:
>
> On Tue, Dec 04, 2007 at 07:25:56AM +0100, Peter Arrenbrecht wrote:
> > On Dec 3, 2007 10:53 PM, Matt Mackall <mpm at selenic.com> wrote:
> > > On Mon, Dec 03, 2007 at 08:49:35PM +0100, Peter Arrenbrecht wrote:
> > > > +import changegroup, util, os, struct, bz2, tempfile, mdiff, hg
> > >
> > > I think that'll give us a circular include, which becomes problematic
> > > when demandloading is disabled. Ugh.
> >
> > So we go with the additional field in the ui class, then?
>
> Yeah, it at least won't have that problem. But it'll be an ugly
> layering violation. I'm tempted to say use setconfig("bundle","base").

How would "use setconfig("bundle","base")" be less of a layering
problem than a new field? Because you don't introduce a specific name
in a generic place? But then we might also just add a new field that
is a map where people can stow any and all such things without
suggesting they're configurable in .hg/hgrc. We would probably have to
dupe this thing like the regular config from the parentui.
-peter


More information about the Mercurial-devel mailing list