[PATCH] Support VISUAL environment variable

Matt Mackall mpm at selenic.com
Tue Dec 4 13:40:38 CST 2007


On Tue, Dec 04, 2007 at 09:32:55PM +0900, Osku Salerma wrote:
> I didn't like it much when Mercurial fired up vi to write my commit
> message in, ignoring my VISUAL=emacs unlike pretty much every other unix
> program out there. The patch below fixes that, and in addition moves the
> editor-finding code to a single place so it's no longer duplicated.
> 
> I guess technically it's a layering violation for util to be calling
> functions in ui objects, so if you really want to avoid that the function
> could be moved to ui.

Please.

> I also didn't update any of the documentation talking about EDITOR, since
> it's scattered all over the place, and the whole point of the patch is
> that things will "just work" for more people without them having to read
> the documentation or change their settings.

Just updating it in hg.1.txt's environment section should be
sufficient.

-- 
Mathematics is the supreme nostalgia of our time.


More information about the Mercurial-devel mailing list