[PATCH] mq: add --setuser and --user options to qnew and qrefresh
peter.arrenbrecht at gmail.com
Mon Dec 17 17:22:32 CST 2007
Brendan, sorry, I discussed this a bit with Patrick on IRC. I also
didn't like "resetuser" and proposed "currentuser", or even
"--user=current" (but this would be a problem for people needing the
string "current" as a user name). So I guess "currentuser", which
Patrick also liked, is able to unite a majority behind it :)
Shall update, and also fix the tests to use a shell function for
repetitive stuff (as Patrick suggested).
On Dec 17, 2007 11:19 PM, Brendan Cully <brendan at kublai.com> wrote:
> On Monday, 17 December 2007 at 11:58, Patrick Mézard wrote:
> > Peter Arrenbrecht a écrit :
> > > # HG changeset patch
> > > # User peter.arrenbrecht at gmail.com
> > > # Date 1197582765 -3600
> > > # Node ID c6892532ed83816be689469794c5409cfdd9f280
> > > # Parent 812dbb08d59a6ccfdb873bb50f752c4e0272c518
> > > mq: add --setuser and --user options to qnew and qrefresh
> > >
> > > These options make qnew and qrefresh add/update the "From:" header (or, if present,
> > > the "# User" header). This allows proper attribution of patches in patch queues
> > > with multiple contributors.
> > +1
> > I am not completely sold to "setuser" option name, I would not have
> > guessed what it does without looking at the documentation. What
> > about "resetuser" or something implying a default value ?
> This patch looks pretty good to me. I agree about the 'setuser' name,
> but I think 'resetuser' sounds like it might remove an existing User
> field. Maybe --currentuser or --defaultuser ?
More information about the Mercurial-devel