"prettify" patchbomb? (was: [PATCH] patchbomb: make "hg email -b" w/o destination work as advertised)

Christian Ebert blacktrash at gmx.net
Mon Dec 17 10:35:49 CST 2007


* Thomas Arendsen Hein on Monday, December 17, 2007 at 13:59:59 +0100
> * Christian Ebert <blacktrash at gmx.net> [20071216 23:19]:
>> # HG changeset patch
>> # User Christian Ebert <blacktrash at gmx.net>
>> # Date 1197842123 -3600
>> # Node ID 585de8ec5401fe96eec4c940d31f19a305b08f0c
>> # Parent  165cda754d9e3bb54fed9e3d0038ad64ff24eae8
>> patchbomb: make "hg email -b" w/o destination work as advertised
> 
> Pushed to crew-stable.

BTW, patchbomb "violates"
<http://www.selenic.com/mercurial/wiki/index.cgi/Basic_Coding_Style>
in several places (overlong lines, no linebreak after colon
etc.), should I "prettify" it?

Also, the use of opts.get is a bit inflationary, imo. Do
something like: "obundle = opts.get('bundle')", and then reuse
obundle? Or is opts.get preferred?

c
-- 
keyword extension for Mercurial (http://selenic.com/mercurial):
<http://www.blacktrash.org/hg/hgkeyword/> (incl. 0.9.2 compatible branch)
Mercurial crew development repository + keyword extension:
<http://www.blacktrash.org/hg/hg-crew-keyword/>


More information about the Mercurial-devel mailing list