[PATCH] hg tag: add/remove multiple tags; run tag hook only once

John Coomes John.Coomes at sun.com
Tue Dec 18 13:08:12 CST 2007


Matt Mackall (mpm at selenic.com) wrote:
> On Mon, Dec 17, 2007 at 04:34:35PM -0800, John Coomes wrote:
> > Patch to allow 'hg tag' to add or remove multiple tags.  Some examples
> > at
> > 
> > http://www.selenic.com/pipermail/mercurial-devel/2007-December/003667.html
> > 
> > The pretag and tag hooks are run once for each tag.  The intent is
> > that all tags should be added, or none, so if any pretag hook (or
> > other correctness check) fails no tags are added.
> > 
> > This also fixes a bug which caused the tag hook to be run twice for a
> > global tag.
> 
> I'm afraid this is a good example of something that should have been
> two patches. I can't really follow the hook bugfix in the midst of
> everything else. Can we get the hook bugfix first? It'll also want to
> go to -stable.

Sure, I'll tease them apart.  I discovered the bug only after making
the other changes, and gave in to the dark side.

-John



More information about the Mercurial-devel mailing list