[PATCH] [RFC] convert: fix --datesort

Maxim Dounin mdounin at mdounin.ru
Tue Dec 18 16:52:22 CST 2007


Hello!

On Thu, 13 Dec 2007, Kirill Smelkov wrote:

> # HG changeset patch
> # User Kirill Smelkov <kirr at mns.spb.ru>
> # Date 1197567565 -10800
> # Node ID 7a1570348d6df8f59289eddaee9452393033b078
> # Parent  eb2f94f6aeabff1638e0ad3c46fcbe80bf4e8fc2
> [RFC] convert: fix --datesort
> 
> The problem is that previously commit.date was used for sorting, but it's a
> string like "1 Jan xxx 2007", so it it wrong to use it for sorting.
> 
> Another problem is that why we are using depth for sorting -- I have no clear
> answer -- it seems to be plain wrong.

As far as I understand, depth is here to make sure parent changeset always 
commited before it's child regardless of dates specified.

I don't think dropping this invariant is a good idea.

Maxim Dounin


More information about the Mercurial-devel mailing list