"prettify" patchbomb? (was: [PATCH] patchbomb: make "hg email -b" w/o destination work as advertised)

Thomas Arendsen Hein thomas at intevation.de
Thu Dec 20 04:06:23 CST 2007


* Christian Ebert <blacktrash at gmx.net> [20071218 02:41]:
> BTW, patchbomb "violates"
> <http://www.selenic.com/mercurial/wiki/index.cgi/Basic_Coding_Style>
> in several places (overlong lines, no linebreak after colon
> etc.), should I "prettify" it?

Sure, that would be nice.

> Also, the use of opts.get is a bit inflationary, imo. Do
> something like: "obundle = opts.get('bundle')", and then reuse
> obundle? Or is opts.get preferred?

opts.get is more explicit, so I'd prefer that unless there are
noticeable performance penalties, but I don't think this is the case
for patchbomb. An exception for this would be if you say e.g.
  bundle = opts.get('bundle') or foobar
(or some other magic after reading the option) in which case the
bundle variable has an additional meaning besides just being a copy
of the option.

Thomas

-- 
thomas at intevation.de - http://intevation.de/~thomas/ - OpenPGP key: 0x5816791A
Intevation GmbH, Osnabrueck - Register: Amtsgericht Osnabrueck, HR B 18998
Geschaeftsfuehrer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner


More information about the Mercurial-devel mailing list