"prettify" patchbomb?

Christian Ebert blacktrash at gmx.net
Sat Dec 29 12:00:29 CST 2007


* Thomas Arendsen Hein on Friday, December 28, 2007 at 16:10:40 +0100
> * Christian Ebert <blacktrash at gmx.net> [20071227 18:59]:
>> Right. I'll wait until the inline/attach patch has gone thru
>> though.
> 
> mpm pushed your overlong lines patch from the 18th.

Overlooked that I had already sent that. Nevermind, I'll just
propose some more stuff, and can update if needed.

>> Ok. And there's no preferred/canonical way concerning
>> opts.get('bundle') vs. opts['bundle'] ?
> 
> opts.get is the safer (and more convenient) thing to use, because
> people directly calling functions in commands.py will not have to
> pass uninteresting options or adjust their python code for new
> options.

I'm convinced you're right, I just can't get my head around how
this could happen for a command defined in an extension. If you
have nothing else to do, an example what help my slow brain a
lot (mq always uses opts['foo']).

c
-- 
I would prefer not to.
--Herman Melville, Bartleby


More information about the Mercurial-devel mailing list