[PATCH 1 of 1] ( take 2 ) change tag computation to avoid surprises in case of multiple heads

[Matt Mackall]

On Sun, Jan 07, 2007 at 07:45:28PM +0100, Georg-W. Koltermann wrote:
> +            self._obsoletetagvalues = {}

Is there a reason this needs to be wider than function scope? In other
words, just do "obsoletetags = {}" please.

> +            def parsetag(line, context, tagsmap):
...
> -                self.tagscache[key] = bin_n
> +                if key in tagsmap:
> +                    self._obsoletetagvalues[(key, tagsmap[key])] = True
> +                if not (key, bin_n) in self._obsoletetagvalues:
> +                    tagsmap[key] = bin_n

What purpose does tagsmap serve? Why can't we just use tagscache?

If it's just so that local tags always override .hgtags, simply flush
the obsoletetags before reading the local tags.

-- 
Mathematics is the supreme nostalgia of our time.