[PATCH] convert: record the source revision in the changelog

Brendan Cully brendan at kublai.com
Fri Jul 13 09:07:35 CDT 2007


On Friday, 13 July 2007 at 06:47, Alexis S. L. Carvalho wrote:
> > +        if commit.branch:
> > +            extra['branch'] = commit.branch
> > +        if commit.rev:
> > +            extra['source_revision'] = commit.rev
> 
> At the time transplant_source was added, we sort of agreed on
> "<extensionprefix>_<field>".

ok. convert_revision?

> Some questions:
> 
> - do we have something useful for the CVS backend here?

My feeling was that the cvsps revision numbers weren't very
meaningful, and that in general it wouldn't be very useful to tack a
fake tree revision number onto a file-based SCM.

> - if so, should we just just set commit.rev in the generic code?  OTOH
>   this wouldn't allow a backend to avoid adding this field...

yes, that last point was the reason I didn't do it in the generic
code.

> - should we also save the name of the source SCM?

we could. In practice I expect that it's pretty easy to
reconstruct. It'll probably be obvious from the revision number anyway
(it is so far).


More information about the Mercurial-devel mailing list