[PATCH 3 of 7] Use wsgi.url_scheme instead of ad-hoc CGI checks

Brendan Cully brendan at kublai.com
Fri Jul 13 10:31:29 CDT 2007


On Friday, 13 July 2007 at 09:22, Wesley J. Landaker wrote:
> On Thursday 12 July 2007 23:56:56 Brendan Cully wrote:
> > On Thursday, 12 July 2007 at 14:48, Wesley J. Landaker wrote:
> > > # HG changeset patch
> > > # User Wesley J. Landaker <wjl at icecavern.net>
> > > # Date 1184270506 21600
> > > # Node ID 9fc9dc548b0e4cc21a95d1681e3f024e1d712f25
> > > # Parent  8f430b1b3025cbd7735585a3ed3911289654e89f
> > > Use wsgi.url_scheme instead of ad-hoc CGI checks.
> > >
> > > Instead of each place in hgweb_mod that needs to check for SSL or get
> > > the protocol scheme (http vs. https) doing it ad-hoc, make them just
> > > look at the wsgi.url_scheme which because of previous patches is now
> > > always set correctly.
> >
> > Applied to crew, with the typos fixed.
> 
> Excellent, thanks. =)
> 
> Any comments (from anyone) on the other patches? I can respin and resubmit 
> if there are things that need to change.

would you mind rediffing against crew tip, and folding typo fixes back
into the source patch?


More information about the Mercurial-devel mailing list