[PATCH 2 of 2] Remove {urlbase} template backward compatibility

Wesley J. Landaker wjl at icecavern.net
Fri Jul 13 12:48:54 CDT 2007


# HG changeset patch
# User Wesley J. Landaker <wjl at icecavern.net>
# Date 1184348613 21600
# Node ID 2acb84a0d4f06b92951f186b5fa5f269cecfc912
# Parent  ea1a254b4a03c1c4a61b6bfb2a5ebbdeb27a17f8
Remove {urlbase} template backward compatibility.

The parent changeset renamed {urlbase} to {baseurl} for various
good reasons, such as it's unification with the [web]/baseurl config
parameter.

Given that {urlbase} was only used in the RSS templates, was not
documented, didn't actually work correctly with HTTPS, and was
previously buggy in respect to it's mismatch with the [web]/baseurl
setting, this patch removes the {urlbase} backwards compatibility,
because it is no longer used in mercurial, and it is very unlikely that
it is used by 3rd party templates (and if so, it's trivial to change).

diff -r ea1a254b4a03 -r 2acb84a0d4f0 mercurial/hgweb/hgweb_mod.py
--- a/mercurial/hgweb/hgweb_mod.py	Fri Jul 13 11:41:04 2007 -0600
+++ b/mercurial/hgweb/hgweb_mod.py	Fri Jul 13 11:43:33 2007 -0600
@@ -814,7 +814,6 @@ class hgweb(object):
                                      defaults={"url": req.url,
                                                "staticurl": staticurl,
                                                "baseurl": baseurl,
-                                               "urlbase": baseurl, # backwards compatibility only
                                                "repo": self.reponame,
                                                "header": header,
                                                "footer": footer,


More information about the Mercurial-devel mailing list