crew/88fc92b0b821: patchbomb.py fix

[Giorgos Keramidas]

On 2007-06-17 20:11, Brendan Cully <brendan at kublai.com> wrote:
> On Monday, 18 June 2007 at 05:53, Giorgos Keramidas wrote:
> > crew changeset 88fc92b0b8214aa677a40075d03df71bce7e21b2 tries to use
> > os['PAGER'] to get a copy of os.environ['PAGER'] and breaks the
> > patchbomb extension.
>
> Thanks. I've pushed this much shorter fix:

I considered using this form of the fix, but I was unsure about any
performance loss caused by going through os.environ[] twice, hence the
use of `pager' as an intermediate copy of os.environ['PAGER'] in the
original patch.

I'm happy either way, though.  Thanks :-)

> # HG changeset patch
> # User Brendan Cully <brendan at kublai.com>
> # Date 1182136175 25200
> # Node ID 64c415d2553ae5dc90b244f37ad6e5c3dad94ce8
> # Parent  88fc92b0b8214aa677a40075d03df71bce7e21b2
> patchbomb: fix PAGER buglet introduced in 88fc92b0b821
>
> diff -r 88fc92b0b821 -r 64c415d2553a hgext/patchbomb.py
> --- a/hgext/patchbomb.py        Sun Jun 17 20:35:43 2007 +0200
> +++ b/hgext/patchbomb.py        Sun Jun 17 20:09:35 2007 -0700
> @@ -383,7 +383,7 @@ def patchbomb(ui, repo, *revs, **opts):
>              ui.status('Displaying ', m['Subject'], ' ...\n')
>              ui.flush()
>              if 'PAGER' in os.environ:
> -                fp = os.popen(os['PAGER'], 'w')
> +                fp = os.popen(os.environ['PAGER'], 'w')
>              else:
>                  fp = ui
>              try: