crew/88fc92b0b821: patchbomb.py fix

Brendan Cully brendan at kublai.com
Sun Jun 17 22:29:47 CDT 2007


On Monday, 18 June 2007 at 06:23, Giorgos Keramidas wrote:
> On 2007-06-17 20:11, Brendan Cully <brendan at kublai.com> wrote:
> > On Monday, 18 June 2007 at 05:53, Giorgos Keramidas wrote:
> > > crew changeset 88fc92b0b8214aa677a40075d03df71bce7e21b2 tries to use
> > > os['PAGER'] to get a copy of os.environ['PAGER'] and breaks the
> > > patchbomb extension.
> >
> > Thanks. I've pushed this much shorter fix:
> 
> I considered using this form of the fix, but I was unsure about any
> performance loss caused by going through os.environ[] twice, hence the
> use of `pager' as an intermediate copy of os.environ['PAGER'] in the
> original patch.

dict lookup is fast, and this is not a performance-critical piece of
code :)


More information about the Mercurial-devel mailing list